Ticket #164 (new defect)

Opened 5 months ago

ercompile output header path error

Reported by: ambvi01 Assigned to: admin
Priority: major Milestone: asap
Component: compile Version: svnroot
Keywords: Cc:

Description

The ercompile program we use to build headers seems to have a problem dealing with the output header path if the input message file is not in the current working directory and specified with an absolute filename.

For example if you have file.msg in / and you run ercompile in / you will get file.h, but if you have /some/folder/file.msg and run ercompile from / you will get /some/folderfile.msg

The last directory delimiter is lost when attaching the fpre.

I have written a patch for this and tested it to compile and function correctly on fedora 8 32bit. The change is very minor, and uses a ternary operator. if the moderator feels this is "confusing" then it can be changed into a STcopy.

I have tested the following types of input message file paths:

1. ercompile -h file.msg

2. ercompile -h lots/of/deep/folders/file.msg

3. ercompile -h ./file.msg

4. ercompile -h ./more/deep/folders/file.msg

5. ercompile -h /file.msg

6. ercompile -h /and/the/same/sorta/thing/file.msg

All of which PASS with my patch. Without my patch, all FAIL. Except for test 1.

Attached patch is for svnroot/trunk

Attachments

ercomp_header_output.patch (509 bytes) - added by ambvi01 on 06/12/08 16:43:08.
Fix for ercomp.c to handle output header paths

Change History

06/12/08 16:43:08 changed by ambvi01

  • attachment ercomp_header_output.patch added.

Fix for ercomp.c to handle output header paths